Which module is responsible for Lane and Pool resizing?

rip222 · September 7, 2021, 2:24am

Thank you @barmac!
I’ve got a question though. Is it intended that when target is Lane resizeShape of modeling is executed instead of resizeLane?

github.com

bpmn-io/bpmn-js/blob/fea7eebb157b47ef23bcd7b3abe931d6f1429215/lib/features/auto-resize/BpmnAutoResize.js#L33

    
      
          
          
/**
           * Resize shapes and lanes.
           *
           * @param {djs.model.Shape} target
           * @param {Bounds} newBounds
           * @param {Object} hints
           */
          BpmnAutoResize.prototype.resize = function(target, newBounds, hints) {
          
          
  if (is(target, 'bpmn:Participant')) {
              this._modeling.resizeLane(target, newBounds, null, hints);
            } else {
              this._modeling.resizeShape(target, newBounds, null, hints);
            }
          };

Shouldn’t it be something like this?

if (is(target, 'bpmn:Participant') || is(target, 'bpmn:Lane')) {
    this._modeling.resizeLane(target, newBounds, null, hints);
  } else {
    this._modeling.resizeShape(target, newBounds, null, hints);
  }